Add instances for Data.Set #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
approved these changes
Jan 4, 2019
|
Thanks @thomashoneyman! As far as I'm concerned, this is ready to merge. Incidentally, this is being driven by some prototyping work I'm doing on typed-wire to bring it up to date. Working on a technology prototype for a client that's Haskell backend and PS frontend. |
|
Great! I'll go ahead and merge. If you happen to be using Halogen for your prototype, you might be able to lift quite a bit from the Halogen RealWorld project. Good luck with typed-wire! |
|
@thomashoneyman Indeed, the frontend is Halogen, and your RealWorld work is pretty much the next thing on my reading list. I owe you a huge debt of gratitude for that! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
EncodeJsonandDecodeJsoninstances for Data.Set.Set. Since we already have theordered-collectionsdependency, this seems like an easy win.Let me know what you think. Thank you!
-be